Consistent alignment for 'project settings page confirmation' buttons #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it'd be best to scope the |
…or-modrinth-edits into button-alignment-fix
|
Styles are now scoped to |
Geometrically
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, project pages such as General, Tags, Links etc. have inconsistent locations for the 'Save Changes' button:
Right Side: General, Tags, Links
Left Side: Description, License
This PR changes 1 line of css for the .button-group class, unifying the buttons on the left side of the button group.
Things to consider:
I haven't tested the entire site to check where else .button-group is used. If it's used in unexpected places there may be unforseen layout shifts from this PR (Scoping the styles to each page would likely be preferable if this is the case)Scoping was neededButton on the right (current live site)
Button on the left